Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitmproxy: 5.3.0 -> 6.0.2 #113948

Merged
merged 3 commits into from Mar 2, 2021
Merged

mitmproxy: 5.3.0 -> 6.0.2 #113948

merged 3 commits into from Mar 2, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Feb 21, 2021

Motivation for this change

Success of #110091

  • Update to 6.0.2
  • Limit to newer Python releases
  • Sync requirements to upstream for 6.x
  • Switch to pytestCheckHook
  • Formatting with nixpkgs-fmt
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Feb 21, 2021

Result of nixpkgs-review pr 113948 run on x86_64-linux 1

2 packages built:
  • mitmproxy (python38Packages.mitmproxy)
  • python39Packages.mitmproxy

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 113948 at b022c9f1 run on aarch64-linux 1

2 packages built:

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 113948 run on x86_64-linux 1

2 packages built:
  • mitmproxy (python38Packages.mitmproxy)
  • python39Packages.mitmproxy

Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, functionally.

requests
];

doCheck = !stdenv.isDarwin;

postPatch = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't move pieces of code around when there is no need to.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-hammer has complained about the ordering.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me when we change bigger parts anyway.

@fabaff fabaff merged commit 25c7c6a into NixOS:master Mar 2, 2021
@fabaff fabaff deleted the bump-mitmproxy branch March 2, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants