zotero: 5.0.89 -> 5.0.95

[i077]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 113964 at 328019b run on x86_64-linux 1

1 package built:

• zotero

4 suggestions:

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/applications/office/zotero/default.nix:141:3:

      |
  141 |   meta = with lib; {
      |   ^
  

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/applications/office/zotero/default.nix:106:3:

      |
  106 |   installPhase =
      |   ^
  

• warning: patch-phase

  patchPhase should not be overridden, use postPatch instead.

  Near pkgs/applications/office/zotero/default.nix:89:3:

     |
  89 |   patchPhase = ''
     |   ^
  

• warning: unclear-gpl

  agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

  Near pkgs/applications/office/zotero/default.nix:144:5:

      |
  144 |     license = licenses.agpl3;
      |     ^
  

---

Result of nixpkgs-review pr 113964 at 328019b run on aarch64-linux 1

1 package built:

• zotero

4 suggestions:

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/applications/office/zotero/default.nix:141:3:

      |
  141 |   meta = with lib; {
      |   ^
  

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/applications/office/zotero/default.nix:106:3:

      |
  106 |   installPhase =
      |   ^
  

• warning: patch-phase

  patchPhase should not be overridden, use postPatch instead.

  Near pkgs/applications/office/zotero/default.nix:89:3:

     |
  89 |   patchPhase = ''
     |   ^
  

• warning: unclear-gpl

  agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

  Near pkgs/applications/office/zotero/default.nix:144:5:

      |
  144 |     license = licenses.agpl3;
      |     ^
  

[davidak]

@i077 can you have a look at the suggestions from @r-rmcgibbo comment?

Maybe add yourself as maintainer, since there is currently none.

[i077]

@davidak done, and bin/zotero still runs on my end.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 113964 run on x86_64-linux 1

1 package built:

• zotero

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

zotero:

agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

Near pkgs/applications/office/zotero/default.nix:144:5:

    |
144 |     license = licenses.agpl3;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
patchPhase should not be overridden, use postPatch instead.

Near pkgs/applications/office/zotero/default.nix:89:3:

   |
89 |   patchPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md
Package does not have a maintainer. Consider adding yourself?

Near pkgs/applications/office/zotero/default.nix:141:3:

    |
141 |   meta = with lib; {
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
installPhase should probably contain runHook preInstall and runHook postInstall.

Near pkgs/applications/office/zotero/default.nix:106:3:

    |
106 |   installPhase =
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

[davidak]

Result of nixpkgs-review pr 113964 1

1 package built:

• zotero

[davidak]

Thanks @i077!

Could you squash the last commit from @SuperSandro2000 into your last one?

[i077]

Whoops, didn't catch that small mistake. Fixed up my last commit with Sandro's.