Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

androidStudioPackages: change --set JAVA_HOME to --set-default in wra… #114223

Merged
merged 1 commit into from Mar 1, 2021
Merged

androidStudioPackages: change --set JAVA_HOME to --set-default in wra… #114223

merged 1 commit into from Mar 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 24, 2021

Motivation for this change

Pull request #112667, tadfisher points out they would like to be able to override the jdk package used.
This allows that using JAVA_HOME in the user's environment.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 114223 at 7230b47 run on x86_64-linux 1

4 packages built:
  • android-studio (androidStudioPackages.stable)
  • androidStudioPackages.beta
  • androidStudioPackages.canary
  • androidStudioPackages.dev

@ghost ghost mentioned this pull request Mar 1, 2021
Merged
10 tasks
primeos
primeos approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good approach to me, thanks :)

@primeos primeos merged commit c4e4ba0 into NixOS:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-rmcgibbo @primeos @meutraa