Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rnp: init at 0.14.0-gffcfb63 #114238

Closed
wants to merge 2 commits into from
Closed

rnp: init at 0.14.0-gffcfb63 #114238

wants to merge 2 commits into from

Conversation

ribose-jeffreylau
Copy link
Contributor

@ribose-jeffreylau ribose-jeffreylau commented Feb 24, 2021

Motivation for this change

Package rnp, a high performance C++ OpenPGP library, fully compliant to RFC 4880.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Feb 24, 2021

Result of nixpkgs-review pr 114238 at 95007f71 run on x86_64-linux 1

1 package failed to build:

Result of nixpkgs-review pr 114238 at 95007f71 run on aarch64-linux 1

1 package failed to build:

Copy link
Member

@humancalico humancalico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a committer but still left some reviews.

pkgs/tools/security/rnp/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/rnp/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/rnp/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/rnp/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/rnp/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/rnp/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 114238 run on x86_64-darwin 1

1 package built:
  • rnp

@ribose-jeffreylau
Copy link
Contributor Author

ribose-jeffreylau commented Apr 7, 2021

Superceded by 0.15.0

@SuperSandro2000
Copy link
Member

You could have updated that PR instead.

@ribose-jeffreylau
Copy link
Contributor Author

🙇‍♂️ Sorry, will do next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants