Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcpflow: 1.5.2 -> 1.6.1 #114262

Merged
merged 1 commit into from Feb 25, 2021
Merged

tcpflow: 1.5.2 -> 1.6.1 #114262

merged 1 commit into from Feb 25, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented Feb 24, 2021

The substituteInPlace "patch" is required to fix the following build error:

datalink.cpp:177:27: error: format not a string literal and no format
arguments
[8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wformat-security-Werror=format-security8;;]
  177 |         DEBUG(6)(s.c_str());
      |                           ^

This also removes me as maintainer since I don't use tcpflow anymore.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The substituteInPlace "patch" is required to fix the following build error:
datalink.cpp:177:27: error: format not a string literal and no format
arguments
[8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wformat-security-Werror=format-security8;;]
  177 |         DEBUG(6)(s.c_str());
      |                           ^

This also removes me as maintainer since I don't use tcpflow anymore.
@primeos
Copy link
Member Author

primeos commented Feb 24, 2021

@obadz @7c6f434c what's your status? Do we need a new maintainer for tcpflow or will you take care of updates?

@r-rmcgibbo
Copy link

r-rmcgibbo commented Feb 24, 2021

Result of nixpkgs-review pr 114262 at 682696d run on x86_64-linux 1

1 package built:
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/tools/networking/tcpflow/default.nix:42:5:

       |
    42 |     license     = licenses.gpl3;
       |     ^
    

Result of nixpkgs-review pr 114262 at 682696d run on aarch64-linux 1

1 package built:
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/tools/networking/tcpflow/default.nix:42:5:

       |
    42 |     license     = licenses.gpl3;
       |     ^
    

@SuperSandro2000 SuperSandro2000 merged commit 57231d7 into NixOS:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants