rustPlatform.cargoBuildHook: do not use when buildPhase is set

[danieldk]

Motivation for this change

See #114659.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[collares]

Would it be appropriate to land this on master instead of staging, since it fixes a channel blocker? There are 9 packages that use buildRustPackage and do buildPhase = null; in nixpkgs.

[worldofpeace]

@collares I think this change make sense, but I think we're agreed on that packages like gnome-tour and fractal should add rustc and cargo to nativeBuildInputs, the meson files try to do this anyway, and just use cargoSetupHook. We were only hacking around to just use it for setup anyway (IIRC).

[worldofpeace]

i.e I can just deliver those smaller fixes to master, and this can go through staging. But if @danieldk disagrees with what I just said than I would reconsider.

[collares]

@worldofpeace That's even better! I just suggested landing this on master because it would reduce the urgency of fixing it the "proper" way for all affected packages, but if you were already planning to fix the channel-blocking ones quickly then it's definitely the best approach. Thanks a lot!

Since I guess most packages won't be channel-blocking, here's a list of maintainers of affected packages (excluding gnome-tour and fractal which were already mentioned):

• gnome-podcasts: GNOME maintainers
• shortwave: @lasandell
• contrast: @jtojnar
• zcash: @rht @tkerber
• gnvim: @minijackson
• newsflash: @MetaDark
• sequoia: @minijackson, @doronbehar

If you were tagged above, you were using buildRustPackage but overriding its buildPhase, which might be a sign that you can benefit from recent improvements in the Rust infrastructure (cargoSetupHook in particular).

[danieldk]

i.e I can just deliver those smaller fixes to master, and this can go through staging. But if @danieldk disagrees with what I just said than I would reconsider.

I fully agree. Merging this results in a lot of rebuilds.

[SuperSandro2000]

Would it be appropriate to land this on master instead of staging, since it fixes a channel blocker? There are 9 packages that use buildRustPackage and do buildPhase = null; in nixpkgs.

No, because then everyone would need to rebuild all rust and python packages for the next half day or day.

[jonringer]

I think this is superceded by #114716

[danieldk]

I think this is superceded by #114716

Yep, that's a superset. Closing this.