Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptopp: run configure.sh before make #114707

Merged
merged 1 commit into from Mar 1, 2021
Merged

cryptopp: run configure.sh before make #114707

merged 1 commit into from Mar 1, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Mar 1, 2021

Motivation for this change

This prevents failure on aarch64-darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS (aarch64)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bobrik bobrik mentioned this pull request Mar 1, 2021
Merged
21 tasks
@ofborg ofborg bot requested a review from c0bw3b March 1, 2021 00:13
@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 1, 2021 •
edited

Result of nixpkgs-review pr 114707 at 5b91e71e run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libsForQt512.plasma-vault
  • ring-daemon
10 packages failed to build:
2 suggestions:
  • warning: unused-argument

    Unused argument: nasm.
    Near pkgs/development/libraries/crypto++/default.nix:1:33:

      |
1 | { lib, stdenv, fetchFromGitHub, nasm, which
  |                                 ^
  • warning: unused-argument

    Unused argument: which.
    Near pkgs/development/libraries/crypto++/default.nix:1:39:

      |
1 | { lib, stdenv, fetchFromGitHub, nasm, which
  |                                       ^

Result of nixpkgs-review pr 114707 at 5b91e71e run on aarch64-linux 1

2 packages marked as broken and skipped:
  • libsForQt512.plasma-vault
  • ring-daemon
8 packages failed to build:
2 suggestions:
  • warning: unused-argument

    Unused argument: nasm.
    Near pkgs/development/libraries/crypto++/default.nix:1:33:

      |
1 | { lib, stdenv, fetchFromGitHub, nasm, which
  |                                 ^
  • warning: unused-argument

    Unused argument: which.
    Near pkgs/development/libraries/crypto++/default.nix:1:39:

      |
1 | { lib, stdenv, fetchFromGitHub, nasm, which
  |                                       ^

@bobrik
Copy link
Contributor Author

bobrik commented Mar 1, 2021

This managed to break aarch64-linux, so I amended to only apply on Darwin.

@bobrik
Copy link
Contributor Author

bobrik commented Mar 1, 2021

The amule failure is from #110901.

@bobrik
Copy link
Contributor Author

bobrik commented Mar 1, 2021

Amended again to make all platforms work with this.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 114707 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libsForQt512.plasma-vault
  • ring-daemon
3 packages failed to build and already failed to build on hydra master:
7 packages built:
  • cryfs
  • cryptopp
  • libsForQt5.plasma-vault (libsForQt515.plasma-vault ,plasma5Packages.plasma-vault)
  • libsForQt514.plasma-vault
  • megacmd
  • megasync
  • rockbox_utility

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

amuleDaemon:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/networking/p2p/amule/default.nix:5:20:

  |
5 | , fetchFromGitHub, fetchpatch, stdenv, lib, zlib, wxGTK, perl, cryptopp, libupnp, gettext, libpng ? null
  |                    ^
amuleGui:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/networking/p2p/amule/default.nix:5:20:

  |
5 | , fetchFromGitHub, fetchpatch, stdenv, lib, zlib, wxGTK, perl, cryptopp, libupnp, gettext, libpng ? null
  |                    ^
amule:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/networking/p2p/amule/default.nix:5:20:

  |
5 | , fetchFromGitHub, fetchpatch, stdenv, lib, zlib, wxGTK, perl, cryptopp, libupnp, gettext, libpng ? null
  |                    ^
cryfs:

warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.

Near pkgs/tools/filesystems/cryfs/default.nix:72:5:

   |
72 |     license     = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

cryptopp:

warning: unused-argument
Unused argument: nasm.
Near pkgs/development/libraries/crypto++/default.nix:1:33:

  |
1 | { lib, stdenv, fetchFromGitHub, nasm, which
  |                                 ^

warning: unused-argument
Unused argument: which.
Near pkgs/development/libraries/crypto++/default.nix:1:39:

  |
1 | { lib, stdenv, fetchFromGitHub, nasm, which
  |                                       ^
libsForQt514.plasma-vault:

warning: unclear-gpl
fdl12 is a deprecated license, check if project uses fdl12Plus or fdl12Only and change meta.license accordingly.

Near pkgs/desktops/plasma-5/default.nix:85:15:

   |
85 |               license = with lib.licenses; [
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

libsForQt5.plasma-vault:

warning: unclear-gpl
fdl12 is a deprecated license, check if project uses fdl12Plus or fdl12Only and change meta.license accordingly.

Near pkgs/desktops/plasma-5/default.nix:85:15:

   |
85 |               license = with lib.licenses; [
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

megasync:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/contrib/clang-analyzer.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/contrib/build_pdfium/build.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/contrib/build_ffmpeg/ffmpeg/build_minimum.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/clean.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-webrtc.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-openssl.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-mediainfolib.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-libwebsockets.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-libuv.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-libsodium.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-curl.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-cryptopp.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-cares.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-all.sh'
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/autogen.sh'

Please check the offending substituteInPlace for typos or changes in source.

warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/contrib/clang-analyzer.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/contrib/build_pdfium/build.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/contrib/build_ffmpeg/ffmpeg/build_minimum.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/clean.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-webrtc.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-openssl.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-mediainfolib.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-libwebsockets.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-libuv.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-libsodium.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-curl.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-cryptopp.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-cares.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-all.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/autogen.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/applications/misc/megasync/default.nix:9:3:

  |
9 | , fetchpatch
  |   ^
rockbox_utility:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/tools/misc/rockbox-utility/default.nix:53:5:

   |
53 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@bobrik
cryptopp: run configure.sh before make
2f00f46 
This prevents failure on `aarch64-darwin`.
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 114707 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libsForQt512.plasma-vault
  • ring-daemon
3 packages failed to build and already failed to build on hydra master:
7 packages built:
  • cryfs
  • cryptopp
  • libsForQt5.plasma-vault (libsForQt515.plasma-vault ,plasma5Packages.plasma-vault)
  • libsForQt514.plasma-vault
  • megacmd
  • megasync
  • rockbox_utility

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

amuleDaemon:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/networking/p2p/amule/default.nix:5:20:

  |
5 | , fetchFromGitHub, fetchpatch, stdenv, lib, zlib, wxGTK, perl, cryptopp, libupnp, gettext, libpng ? null
  |                    ^
amuleGui:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/networking/p2p/amule/default.nix:5:20:

  |
5 | , fetchFromGitHub, fetchpatch, stdenv, lib, zlib, wxGTK, perl, cryptopp, libupnp, gettext, libpng ? null
  |                    ^
amule:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/networking/p2p/amule/default.nix:5:20:

  |
5 | , fetchFromGitHub, fetchpatch, stdenv, lib, zlib, wxGTK, perl, cryptopp, libupnp, gettext, libpng ? null
  |                    ^
cryfs:

warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.

Near pkgs/tools/filesystems/cryfs/default.nix:72:5:

   |
72 |     license     = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

cryptopp:

warning: unused-argument
Unused argument: nasm.
Near pkgs/development/libraries/crypto++/default.nix:1:33:

  |
1 | { lib, stdenv, fetchFromGitHub, nasm, which
  |                                 ^

warning: unused-argument
Unused argument: which.
Near pkgs/development/libraries/crypto++/default.nix:1:39:

  |
1 | { lib, stdenv, fetchFromGitHub, nasm, which
  |                                       ^
libsForQt514.plasma-vault:

warning: unclear-gpl
fdl12 is a deprecated license, check if project uses fdl12Plus or fdl12Only and change meta.license accordingly.

Near pkgs/desktops/plasma-5/default.nix:85:15:

   |
85 |               license = with lib.licenses; [
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

libsForQt5.plasma-vault:

warning: unclear-gpl
fdl12 is a deprecated license, check if project uses fdl12Plus or fdl12Only and change meta.license accordingly.

Near pkgs/desktops/plasma-5/default.nix:85:15:

   |
85 |               license = with lib.licenses; [
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

megasync:

warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/clean.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-cryptopp.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-libsodium.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-all.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-libuv.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-cares.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-openssl.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-webrtc.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-mediainfolib.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-curl.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/bindings/ios/3rdparty/build-libwebsockets.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/autogen.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/contrib/build_ffmpeg/ffmpeg/build_minimum.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/contrib/build_pdfium/build.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/MEGASync/mega/contrib/clang-analyzer.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/applications/misc/megasync/default.nix:9:3:

  |
9 | , fetchpatch
  |   ^
rockbox_utility:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/tools/misc/rockbox-utility/default.nix:53:5:

   |
53 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@SuperSandro2000 SuperSandro2000 merged commit a205891 into NixOS:master Mar 1, 2021
@bobrik bobrik deleted the ivan/cryptopp-configure branch March 6, 2021 22:16
@edrex edrex mentioned this pull request Sep 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@c0bw3b c0bw3b Awaiting requested review from c0bw3b

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobrik @r-rmcgibbo @SuperSandro2000