Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube: 1.17.1 -> 1.18.0 #114797

Merged
merged 1 commit into from Mar 3, 2021

Conversation

Chili-Man
Copy link
Contributor

@Chili-Man Chili-Man commented Mar 2, 2021

Motivation for this change

https://github.com/kubernetes/minikube/releases/tag/v1.18.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 2, 2021

Result of nixpkgs-review pr 114797 at 13be7fd run on aarch64-linux 1

2 packages built:

Result of nixpkgs-review pr 114797 at 13be7fd run on x86_64-linux 1

2 packages built:

@fabaff
Copy link
Member

fabaff commented Mar 2, 2021

Result of nixpkgs-review pr 114797 run on x86_64-linux 1

2 packages built:
  • docker-machine-kvm2
  • minikube

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...ew/pr-114797]$ ./results/minikube/bin/minikube version
minikube version: v1.18.0
commit: v1.18.0
ew/pr-114797]$ ./results/minikube/bin/minikube status
🤷  Profile "minikube" not found. Run "minikube profile list" to view all profiles.
👉  To start a cluster, run: "minikube start"

Update looks good to me.

@SuperSandro2000 SuperSandro2000 merged commit 6464891 into NixOS:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants