Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-docs: 0.9.1 -> 0.11.2 #114803

Merged
merged 1 commit into from Mar 3, 2021
Merged

Conversation

snoord
Copy link
Contributor

@snoord snoord commented Mar 2, 2021

Motivation for this change

0.9.1 has been out of date for a while now, so this change brings
terraform-docs inline with the current version 0.11.2.

The owner of the repository has changed from segmentio to terraform-docs
since the last pull request.

This commit also introduces the use of buildGoModule in place of
buildGoPackage, so that we can avoid generating a deps.nix file for
module dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

A deps.nix file (generated from vgo2nix) has also been added for use
with the goDeps argument of buildGoPackage, as terraform-docs would not
build without it.

Can we use buildGoModule instead?

@snoord
Copy link
Contributor Author

snoord commented Mar 3, 2021

A deps.nix file (generated from vgo2nix) has also been added for use
with the goDeps argument of buildGoPackage, as terraform-docs would not
build without it.

Can we use buildGoModule instead?

This didn't even occur to me tbh, I'm sure it's possible. I'll give it a go :)

The owner of the repository has changed from segmentio to terraform-docs
since the last pull request.

This commit also introduces the use of buildGoModule in place of
buildGoPackage, so that we can avoid generating a deps.nix file for
module dependencies.
@ofborg ofborg bot requested a review from kalbasit March 3, 2021 02:17
@zimbatm zimbatm merged commit e0a6314 into NixOS:master Mar 3, 2021
@snoord snoord deleted the terraform-docs-v0.11.2 branch March 3, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants