Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golint: 20181026 -> 20201208 #114807

Merged
merged 1 commit into from Mar 2, 2021
Merged

golint: 20181026 -> 20201208 #114807

merged 1 commit into from Mar 2, 2021

Conversation

tomberek
Copy link
Contributor

@tomberek tomberek commented Mar 2, 2021

bump and use Go modules to build

Motivation for this change

changes to golint rules

Things done

removed deps.nix

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bump and use Go modules to build
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 114807 at dacd812 run on x86_64-linux 1

2 packages built:

@fabaff
Copy link
Member

fabaff commented Mar 2, 2021

Result of nixpkgs-review pr 114807 run on x86_64-linux 1

2 packages built:
  • golint
  • vimPlugins.vim-go

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...
ew/pr-114807]$ ./results/golint/bin/golint -h
Usage of ./results/golint/bin/golint:
        golint [flags] # runs on package in current directory
        golint [flags] [packages]
[...]

Update looks good to me.

@tomberek tomberek merged commit 2b558b7 into NixOS:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants