Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyper: add required libraries to library path #114820

Merged
merged 1 commit into from Mar 3, 2021

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented Mar 2, 2021

Motivation for this change

hyper was unable to run and resulted in the following error:

/nix/store/n7y10kx18wpw3asm4zhansw819kdfznx-hyper-3.0.2/bin/hyper: error while loading shared libraries: libgtk-3.so.0: cannot open shared object file: No such file or directory

ldd showed:

ldd /nix/store/n7y10kx18wpw3asm4zhansw819kdfznx-hyper-3.0.2/bin/hyper
...
	libnode.so => not found
...
	libgtk-3.so.0 => not found
	libgdk-3.so.0 => not found
...
	libatk-bridge-2.0.so.0 => not found
...
	libffmpeg.so => not found
...

I added the missing libraries and also added $out/opt/hyper to the library path to make sure it can find libnode and libffmpeg.

After these changes hyper was able to run on my system.

I also run nixfmt, so the file was formatted accordingly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 114820 at abd68595 run on x86_64-linux 1

1 package built:
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/terminal-emulators/hyper/default.nix:56:3:

       |
    56 |   installPhase = ''
       |   ^
    

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 2, 2021

I also run nixfmt, so the file was formatted accordingly.

Please use nixpkgs-fmt instead because it does not enforce 80 line length.

Comment on lines 46 to 47
url =
"https://github.com/zeit/hyper/releases/download/${version}/hyper_${version}_amd64.deb";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url =
"https://github.com/zeit/hyper/releases/download/${version}/hyper_${version}_amd64.deb";
url = "https://github.com/zeit/hyper/releases/download/${version}/hyper_${version}_amd64.deb";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants