Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gops: 0.3.15 -> 0.3.16 #114832

Merged
merged 1 commit into from Mar 3, 2021
Merged

gops: 0.3.15 -> 0.3.16 #114832

merged 1 commit into from Mar 3, 2021

Conversation

pborzenkov
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit March 2, 2021 12:02
@fabaff
Copy link
Member

fabaff commented Mar 2, 2021

Result of nixpkgs-review pr 114832 run on x86_64-linux 1

1 package built:
  • gops

fabaff
fabaff approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

...ew/pr-114832]$ ./results/gops/bin/gops
11168 11108 gops  go1.16 /nix/store/25yc8hwvb2fpqz59hd0p0lwj5j7043j4-gops-0.3.16/bin/gops
[...]

Update looks good to me.

@SuperSandro2000 SuperSandro2000 merged commit 49f51c6 into NixOS:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pborzenkov @fabaff @SuperSandro2000