Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinentry_mac: make it compile on arm64 #114893

Merged
merged 1 commit into from Mar 6, 2021
Merged

pinentry_mac: make it compile on arm64 #114893

merged 1 commit into from Mar 6, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Mar 2, 2021

Motivation for this change

This fixes gnupg under #105026.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS (aarch64 + x86_64)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Mar 3, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rebase master

pkgs/tools/security/pinentry/mac.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

/rebase master

@github-actions github-actions bot changed the base branch from staging to master March 3, 2021 00:07
@github-actions github-actions bot closed this Mar 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2021

Rebased, please reopen the pull request to restart CI

@bobrik
Copy link
Contributor Author

bobrik commented Mar 3, 2021

This needs to go in staging as it depends on #114817.

@bobrik bobrik reopened this Mar 3, 2021
@SuperSandro2000
Copy link
Member

/rebase staging

@github-actions github-actions bot changed the base branch from master to staging March 3, 2021 19:23
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2021

Rebased, please reopen the pull request to restart CI

@github-actions github-actions bot closed this Mar 3, 2021
@bobrik
Copy link
Contributor Author

bobrik commented Mar 5, 2021

@SuperSandro2000 any reason not to merge?

@SuperSandro2000 SuperSandro2000 merged commit 71fa142 into NixOS:staging Mar 6, 2021
@bobrik bobrik deleted the ivan/pinentry-mac-aarch64 branch March 6, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobrik @SuperSandro2000