Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.rfcat: init at 1.9.5 #114914

Merged
merged 1 commit into from Mar 3, 2021
Merged

Conversation

trepetti
Copy link
Contributor

@trepetti trepetti commented Mar 2, 2021

Motivation for this change

Add rfcat: the Swiss Army knife of sub-GHz ISM band radio. Useful for RF protocol debugging and compatible with the popular YARD Stick One from Great Scott Gadgets. Tested on Python 2.7 and 3.8.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 3, 2021

Result of nixpkgs-review pr 114914 at d8a4c24 run on aarch64-linux 1

3 packages built:

Result of nixpkgs-review pr 114914 at 1e722001 run on x86_64-linux 1

3 packages built:

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it help if the udev rules are shipped as well?

pkgs/development/python-modules/rfcat/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 114914 run on x86_64-linux 1

3 packages built:
  • python37Packages.rfcat
  • python38Packages.rfcat
  • python39Packages.rfcat

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 114914 run on x86_64-darwin 1

3 packages built:
  • python37Packages.rfcat
  • python38Packages.rfcat
  • python39Packages.rfcat

@SuperSandro2000 SuperSandro2000 merged commit 1c67e5a into NixOS:master Mar 3, 2021
@trepetti trepetti deleted the rfcat branch March 3, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants