Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waybar: fix compatibility with kernels >=5.11 #114933

Merged
merged 2 commits into from Mar 3, 2021

Conversation

lovesegfault
Copy link
Member

Motivation for this change

Fixes #114870

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 3, 2021

Result of nixpkgs-review pr 114933 at fcb969e run on aarch64-linux 1

1 package built:
1 suggestion:
  • warning: meson-cmake

    Meson uses CMake as a fallback dependency resolution method and it likely is not necessary here. The message about cmake not being found is purely informational.

    Near pkgs/applications/misc/waybar/default.nix:51:3:

       |
    51 |   nativeBuildInputs = [
       |   ^
    

Result of nixpkgs-review pr 114933 at fcb969e run on x86_64-linux 1

1 package built:
1 suggestion:
  • warning: meson-cmake

    Meson uses CMake as a fallback dependency resolution method and it likely is not necessary here. The message about cmake not being found is purely informational.

    Near pkgs/applications/misc/waybar/default.nix:51:3:

       |
    51 |   nativeBuildInputs = [
       |   ^
    

@SuperSandro2000 SuperSandro2000 merged commit 6968b05 into NixOS:master Mar 3, 2021
@lovesegfault lovesegfault deleted the waybar-rfkill-fix branch March 3, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

waybar: Wrong size of RFKILL event
3 participants