chromium: Switch from PipeWire 0.2 to the current 0.3.x releases #114979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
This should make it work more reliable and support additional features like window sharing. See [0] for more details. [0]: https://jgrulich.cz/2020/12/18/webrtc-chromium-updates-in-2020/
primeos
force-pushed
the
chromium-pipewire-0.3
branch
from
88d987c
to
36e5fe0
Compare
|
I could successfully use screen sharing but I also realized that this should break |
Mic92
reviewed
Mar 7, 2021
| @@ -161,7 +161,7 @@ in stdenv.mkDerivation { | |||
|
|
|||
| buildCommand = let | |||
| browserBinary = "${chromiumWV}/libexec/chromium/chromium"; | |||
| libPath = lib.makeLibraryPath [ libva pipewire_0_2 ]; | |||
There was a problem hiding this comment.
If we do not have any other use for pipewire_0_2 it should go.
There was a problem hiding this comment.
From a quick git-grep it looks like Mutter still requires it:
pkgs/desktops/gnome-3/core/mutter/3.34/default.nix:, pipewire_0_2
pkgs/desktops/gnome-3/core/mutter/3.34/default.nix: pipewire_0_2 # TODO: backport pipewire 0.3 support
There was a problem hiding this comment.
cc @jtojnar is this still the case?
There was a problem hiding this comment.
Yup, the old version of Mutter used by Pantheon uses 0.2. The current version used by GNOME uses 0.3, obviously.
|
With #115781 merged this is now ready :) |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully make it work more reliable and support additional
features like window sharing. See 0 for more details.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)