gtksourceview4: 4.8.0 -> 4.8.1

[r-ryantm]

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for gtksourceview4 is: ""

meta.homepage for gtksourceview4 is: "https://wiki.gnome.org/Projects/GtkSourceView"

meta.changelog for gtksourceview4 is: ""

Updates performed

• Ran passthru.UpdateScript

To inspect upstream changes

Impact

Checks done (click to expand)

---

• built on NixOS

• The tests defined in passthru.tests, if any, passed

• 0 of 0 passed binary check by having a zero exit code.

• 0 of 0 passed binary check by having the new version present in output.

• found 4.8.1 with grep in /nix/store/d85q0f4da3723m4gm682rfmggvy59d5a-gtksourceview-4.8.1

• directory tree listing: https://gist.github.com/873a95868c0bd80debed61605c2b2902

• du listing: https://gist.github.com/52b7fc0b294b33e6e9b3c12b85769ae5

---

Rebuild report (if merged into master) (click to expand)

74 total rebuild path(s)

22 package rebuild(s)

22 x86_64-linux rebuild(s)
22 i686-linux rebuild(s)
8 x86_64-darwin rebuild(s)
22 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
fractal
gnome-builder
gnome-latex
gnome3.gedit
gnome3.gnome-boxes
gnome3.gnome-calculator
gnome3.gtksourceview4
gnome3.meld
gnome3.sushi
gtkd
gtksourceview4
gtksourceviewmm4
gtranslator
gupnp-tools
meld
rabbitvcs
setzer
tepl
tilix
vala-language-server
virt-manager
xed-editor

Instructions to test this update (click to expand)

---

Either download from Cachix:

nix-store -r /nix/store/d85q0f4da3723m4gm682rfmggvy59d5a-gtksourceview-4.8.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A gtksourceview4 https://github.com/r-ryantm/nixpkgs/archive/2c1aaa27765eb689b06acc9ce3724d4832965b93.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/d85q0f4da3723m4gm682rfmggvy59d5a-gtksourceview-4.8.1
ls -la /nix/store/d85q0f4da3723m4gm682rfmggvy59d5a-gtksourceview-4.8.1/bin

---

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

3 packages failed to build:

• fractal
• gtkd
• tilix

17 packages built:

• gnome-builder
• gnome-latex
• gnome3.gedit
• gnome3.gnome-boxes
• gnome3.gnome-calculator
• gnome3.gtksourceview4
• gnome3.meld
• gnome3.sushi
• gtksourceviewmm4
• gtranslator
• gupnptools (gupnp-tools)
• rabbitvcs
• setzer
• tepl
• vala-language-server
• virtmanager (virt-manager)
• xed-editor

---

Maintainer pings

cc @hedning @jtojnar @worldofpeace @dasj19 for testing.

[jtojnar]

Changes look okay: https://gitlab.gnome.org/GNOME/gtksourceview/-/commit/fde022cc5cb530e34e0e44954147576fa8da291d

[r-rmcgibbo]

Result of nixpkgs-review pr 114981 at 2c1aaa2 run on aarch64-linux 1

2 packages marked as broken and skipped:

• gtkd
• tilix

18 packages failed to build:

• fractal
• gnome-builder
• gnome-latex
• gnome3.gedit
• gnome3.gnome-boxes
• gnome3.gnome-calculator
• gtksourceview4
(gnome3.gtksourceview4)
• meld
(gnome3.meld)
• gnome3.sushi
• gtksourceviewmm4
• gtranslator
• gupnp-tools
• rabbitvcs
• setzer
• tepl
• vala-language-server
• virt-manager
• xed-editor

4 suggestions:

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/development/libraries/gtksourceview/4.x.nix:29:15:

     |
  29 |   patches = [ ./4.x-nix_share_path.patch ];
     |               ^
  

• warning: missing-phase-hooks

  checkPhase should probably contain runHook preCheck and runHook postCheck.

  Near pkgs/development/libraries/gtksourceview/4.x.nix:34:3:

     |
  34 |   checkPhase = ''
     |   ^
  

• warning: unclear-gpl

  lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

  Near pkgs/development/libraries/gtksourceview/4.x.nix:51:5:

     |
  51 |     license = licenses.lgpl21;
     |     ^
  

• warning: unnecessary-parallel-building

  Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

  Near pkgs/development/libraries/gtksourceview/4.x.nix:31:3:

     |
  31 |   enableParallelBuilding = true;
     |   ^
  

[rmcgibbo]

Any idea what these aarch64 errors are? https://gist.github.com/r-rmcgibbo/3fe3a3656d2a163f408fb448d3d4fa7e

They seem to be causing a nontrivial number of downstream errors, and the error is reproduced on hydra: https://hydra.nixos.org/job/nixpkgs/trunk/gtksourceview4.aarch64-linux

[jtojnar]

IIRC that header should be compiled by glib-compile-resources so either that is not done or dependency is not properly declared in the build system so there is a race. Was this a regression?

[rmcgibbo]

The hydra link above makes it look like a regression between 4.8.0 and 4.8.1, I think.

[jtojnar]

Hmm, there was quite a few changes not mentioned in the changelog: https://gitlab.gnome.org/GNOME/gtksourceview/-/compare/4.8.0...4.8.1

This is likely the issue https://gitlab.gnome.org/GNOME/gtksourceview/-/commit/290d2a7258540ca53b37bb4b932e86f1de43e0f2
And the fix will be similar to https://gitlab.gnome.org/GNOME/gtksourceview/-/commit/7ebe797f5443c7274ada1185841c9005a5669d06