Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2n: 0.10.23->1.0.0, rename package to s2n-tls #115004

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Mar 3, 2021

Move to GitHub org AWS from AWSlabs

Motivation for this change

s2n has been renamed to s2n-tls and moved from GitHub org AWSLabs to AWS. Additionally, we've released v1.0.0, to signify this is no longer experimental. Sim-links are in place on GitHub to prevent breakage to out of date urls or artifact downloads.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an alias to alias.nix.

@SuperSandro2000 SuperSandro2000 changed the title s2n: v0.10.23->v1.0.0; Rename package to s2n-tls s2n: 0.10.23->1.0.0; Rename package to s2n-tls Mar 3, 2021
@SuperSandro2000 SuperSandro2000 changed the title s2n: 0.10.23->1.0.0; Rename package to s2n-tls s2n: 0.10.23->1.0.0, rename package to s2n-tls Mar 3, 2021
@dougch dougch marked this pull request as ready for review March 3, 2021 19:51
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115004 run on x86_64-linux 1

1 package built:
  • nixUnstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants