Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-sitter: 0.18.2 -> 0.19.3 #115025

Merged
merged 1 commit into from Mar 16, 2021
Merged

tree-sitter: 0.18.2 -> 0.19.3 #115025

merged 1 commit into from Mar 16, 2021

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Update tree-sitter

Update the grammars and add allGrammars derivation.
nix-build "<nixpkgs>" -A tree-sitter.allGrammars will create a
derivation with symlinks to all the grammars

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 115025 at 81d1cb77 run on x86_64-linux 1

1 package built:
1 suggestion:
  • warning: unused-argument

    Unused argument: fetchurl.
    Near pkgs/development/tools/parsing/tree-sitter/default.nix:5:3:

      |
    5 | , fetchurl
      |   ^
    

@jlesquembre jlesquembre changed the title tree-sitter: 0.18.2 -> 0.19.0 tree-sitter: 0.18.2 -> 0.19.1 Mar 4, 2021
@jlesquembre
Copy link
Member Author

Related PR: #115071

@teto
Copy link
Member

teto commented Mar 7, 2021

0.19.2 is out :s

@jlesquembre jlesquembre changed the title tree-sitter: 0.18.2 -> 0.19.1 tree-sitter: 0.18.2 -> 0.19.2 Mar 8, 2021
@jlesquembre
Copy link
Member Author

jlesquembre commented Mar 8, 2021

@teto Updated to 0.19.2. Let's see if I have to update it again to 0.19.3...

I removed the allGrammars attribute I added for #115071. Instead, I created #115445, I think that's a better way to manage the grammars

@teto
Copy link
Member

teto commented Mar 8, 2021

Let's see if I have to update it again to 0.19.3...

Sry but looking at the treesitter tracker, seems like there is a 0.19.3 upcoming to address 0.19.2 issues :/

@jlesquembre
Copy link
Member Author

Let's see if I have to update it again to 0.19.3...

Sry but looking at the treesitter tracker, seems like there is a 0.19.3 upcoming to address 0.19.2 issues :/

That was expected, at least every update takes me less time, I'm becoming an expert updating the tree-sitter grammars 😆

Update the grammars and add `allGrammars` derivation.
`nix-build "<nixpkgs>" -A tree-sitter.allGrammars` will create a
derivation with symlinks to all the grammars
@jlesquembre jlesquembre changed the title tree-sitter: 0.18.2 -> 0.19.2 tree-sitter: 0.18.2 -> 0.19.3 Mar 9, 2021
@teto
Copy link
Member

teto commented Mar 9, 2021

builds locally with my config (no nixpkgs-review)

@teto teto merged commit fee2e23 into NixOS:master Mar 16, 2021
@teto
Copy link
Member

teto commented Mar 16, 2021

Some of the grammars dont load in neovim master (neovim/neovim#14076 with 0.19.3 support). I am patching neovim to improve the error messsage.

@teto
Copy link
Member

teto commented Mar 16, 2021

some grammars are not ready for 0.19 (lua/nix) apparently so be careful. Hopefully they will be updated shortly.

@jlesquembre jlesquembre deleted the ts branch March 16, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants