Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.coinmarketcap: remove #115050

Merged
merged 1 commit into from Mar 7, 2021
Merged

python3.pkgs.coinmarketcap: remove #115050

merged 1 commit into from Mar 7, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 4, 2021 •
edited

The API was replaced and the library is no longer functional.
It's only user 'home-assistant' is dropping support for it in 2021.3.0

depends on #115016

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
python3.pkgs.coinmarketcap: remove
0da3137 
The API was replaced and the library is no longer functional.
It's only user 'home-assistant' is dropping support for it in 2021.3.0

depends on NixOS#115016
@Mic92 Mic92 mentioned this pull request Mar 4, 2021
Merged
10 tasks
@Mic92 Mic92 marked this pull request as draft March 4, 2021 08:14
@Mic92
Copy link
Member Author

Mic92 commented Mar 4, 2021

Do not merge before #115016

jonringer
jonringer approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once home-assistant is bumped

diff LGTM

@Mic92 Mic92 marked this pull request as ready for review March 7, 2021 13:31
@Mic92
Copy link
Member Author

Mic92 commented Mar 7, 2021

home-assistant got merged.

@Mic92 Mic92 merged commit 1209713 into NixOS:master Mar 7, 2021
@Mic92 Mic92 deleted the coinmarketcap branch March 7, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @jonringer