deluge: shut up ngettext error on webui start

[peterhoeg]

Motivation for this change

deluge would complain loudly on start. Also patch the logger on py38.

Noise from nixpkgs-fmt.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[peterhoeg]

We should do a manual backport to 20.09 when this is merged.

[r-rmcgibbo]

Result of nixpkgs-review pr 115055 at 566f173d run on x86_64-linux 1

1 package built:

• deluge
(deluge-2_x)

1 suggestion:

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/applications/networking/p2p/deluge/default.nix:24:5:

     |
  24 |     (fetchpatch {
     |     ^
  

[peterhoeg]

Hey @rmcgibbo - as for the suggestion regd a patch comment, maybe the bot can check for a file name and adjust the message to something like this:

Please add a comment on the line above, explaining the purpose of this patch unless the file name is sufficiently informative.

[SuperSandro2000]

Does this break anything on other python versions? If not we shouldn't apply this conditionally to prevent bitrot.

[peterhoeg]

This patch is only needed for 3.8, but it will be part of the next deluge release, so we'll just drop the patches then.

[SuperSandro2000]

If by then the default python version migrated to 3.9 this patch will rot here. If it breaks nothing on other versions we can apply it unconditional to definitely notice when it breaks.

[peterhoeg]

Fair enough. Fixed.

[peterhoeg]

@ofborg test deluge