Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove stdenv where not needed #115075

Merged
merged 1 commit into from Mar 4, 2021
Merged

treewide: remove stdenv where not needed #115075

merged 1 commit into from Mar 4, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Mar 4, 2021

Motivation for this change

Analogous to #110687, but performed manually since there wasn't that many.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben requested a review from prusnak March 4, 2021 12:56
@siraben
Copy link
Member Author

siraben commented Mar 4, 2021

Result of nixpkgs-review pr 115075 run on x86_64-darwin 1

1 package built:
  • documentation-highlighter

@ofborg ofborg bot requested a review from grahamc March 4, 2021 13:05
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 115075 at 98f2699 run on x86_64-linux 1

1 package built:
  • documentation-highlighter

@prusnak prusnak removed their request for review March 4, 2021 13:30
@roberth roberth merged commit 89aa017 into NixOS:master Mar 4, 2021
@siraben siraben deleted the stdenv-cleanup branch March 4, 2021 14:51
@attila-lendvai attila-lendvai mentioned this pull request Mar 8, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Lassulus Lassulus Awaiting requested review from Lassulus Lassulus is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@roberth roberth Awaiting requested review from roberth roberth is a code owner

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
6.topic: fetch 6.topic: ocaml 6.topic: python 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @r-rmcgibbo @roberth