Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcl: add wrapQt, remove broken and run nixpkgs-fmt #115097

Merged
merged 1 commit into from Mar 6, 2021

Conversation

storvik
Copy link
Member

@storvik storvik commented Mar 4, 2021

Motivation for this change

Remove broken tag.

Add wrapQt, this is new to me so not sure that I used it correctly. Another options was to disable wrapQt.

Everything I've tested seems to work correctly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@storvik
Copy link
Member Author

storvik commented Mar 6, 2021

Thanks for merging @SuperSandro2000! I stumbled upon #109041 which probably should be closed after merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants