python3Packages.json-schema-for-humans: 0.27.1 -> 0.31.0 #115114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ruuda
approved these changes
Mar 4, 2021
This comment has been minimized.
This comment has been minimized.
|
Why is this a draft? |
|
Because it would be nice if the package builds for Python 3.9. |
fabaff
force-pushed
the
pyre
branch
2 times, most recently
from
1186fed
to
87938cb
Compare
This comment has been minimized.
This comment has been minimized.
|
Down to 19 packages which are following the same pattern. |
| @@ -16,16 +18,26 @@ buildPythonPackage rec { | |||
| sha256 = "1dzs9a1pr23dhbvmnvms2jv7l7jk26023g5ysf0zvnq8b791s6wg"; | |||
| }; | |||
|
|
|||
| patches = lib.optional (pythonAtLeast "3.9") [ | |||
There was a problem hiding this comment.
Can we apply this unconditionally?
There was a problem hiding this comment.
I don't think so. I saw failures if the patch is applied to Python 3.7/3.8. Let me test again.
pkgs/development/python-modules/google-cloud-datastore/default.nix
Outdated
Show resolved
Hide resolved
Which pattern? |
fabaff
changed the title
preCheck = ''
# directory shadows imports
rm -r google
[...]and the builds failed because the |
|
Is that what's causing the |
That's something else [...]
File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/subprocess.py", line 340, in call
with Popen(*popenargs, **kwargs) as p:
File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/subprocess.py", line 858, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/subprocess.py", line 1706, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'isort'
builder for '/nix/store/42h608fmbjf61ymaq87rxvgmz0y73pj3-python3.8-libcst-0.3.17.drv' failed with exit code 1 |
|
@fabaff please resolve the merge conflict. |
Done |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
It looks like that the failing packages are executing ===================== 1219 passed, 100 warnings in 14.97s ======================
Finished executing pytestCheckPhase
pytestcachePhase
pytestCheckPhase
Executing pytestCheckPhase
rm: cannot remove 'google': No such file or directory |
fabaff
force-pushed
the
pyre
branch
2 times, most recently
from
89db764
to
4053c81
Compare
10 tasks
|
Result of 60 packages failed to build:
7 packages built:
|
|
Superseded by #126015 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest upstream release 0.31.0
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)