ardour: add a videoSupport option, harvid: init at 0.8.3, xjadeo: init at 0.8.10 #115121
Conversation
In preparation for the following commits adding ardour-related video tooling and new `videoSupport` option.
ofborg
bot
added
11.by: package-maintainer
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
|
Result of 5 suggestions:
Result of 5 suggestions:
|
mitchmindtree
force-pushed
the
ardour-video
branch
from
65ee58f
to
0b41f26
Compare
mitchmindtree
force-pushed
the
ardour-video
branch
from
0b41f26
to
a1a36a6
Compare
|
Thanks for the thorough review @SuperSandro2000! I believe I've addressed what I can - the changes have been addressed via a rebase of the original commits. Let me know if these sorts of small changes are better addressed with follow-up commits - I assumed I was better off editing the existing commits to make sure the PR still adheres to the CONTRIBUTING.md. |
This comment has been minimized.
This comment has been minimized.
mitchmindtree
force-pushed
the
ardour-video
branch
2 times, most recently
from
9fff389
to
3e76170
Compare
|
OK, second round of review should now be addressed. |
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 3 packages built:
The following issues got detected with the above build packages.
ardour:
warning: unclear-gpl Near pkgs/applications/audio/ardour/default.nix:186:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md |
harvid decodes still images from movie files and serves them via HTTP. Please refer to the meta attribute for more information. This commit is part of a PR aimed at enabling video support in ardour.
xjadeo is the X Jack Video Monitor. Please refer to the meta attribute for more information on xjadeo. This commit is part of a PR aimed at enabling video support in ardour.
This adds a `bool` option that, when set to `true`, enables video
timeline support for the Ardour DAW. This is commonly useful for
soundtrack composition, sound design for film, etc.
When enabled, `videoSupport` ensures that both `harvid` and `xjadeo` are
available to the `ardour6` exe via the PATH. `harvid` decodes the video
stream in real-time to produce still images (I think for thumbnail
support for the timeline?). `xjadeo` acts as a video monitoring window
that whose playback position is synchronised to the Ardour playhead.
`videoSupport` remains disabled by default, preserving the original
behaviour.
Video support can be added to ardour in your system or home
configuration package list with:
```
(ardour.override { videoSupport = true; })
```
mitchmindtree
force-pushed
the
ardour-video
branch
from
3e76170
to
e14c971
Compare
|
OK, I've addressed all mentioned formatting nits and added a new commit changing the ardour meta license attribute from gpl2 to gpl2Plus as requested by the automated check. |
|
Builds for me, both with video enabled and disabled, linux x86_64. |
| description = | ||
| "Decodes still images from movie files and serves them via HTTP"; |
There was a problem hiding this comment.
nixfmt is not the official formatter for nixpkgs and we do not have a ~80 line length limit. It is totally fine to not linebreak a 120 or even 240 character URL and in this example the line break only stretches the file instead of making it more reable.
| @@ -158,6 +163,10 @@ stdenv.mkDerivation rec { | |||
| "$out/share/icons/hicolor/''${size}x''${size}/apps/ardour6.png" | |||
| done | |||
| install -vDm 644 "ardour.1"* -t "$out/share/man/man1" | |||
| '' + lib.optionalString videoSupport '' | |||
| # `harvid` and `xjadeo` must be accessible in `PATH` for video to work. | |||
There was a problem hiding this comment.
| # `harvid` and `xjadeo` must be accessible in `PATH` for video to work. | |
| # `harvid` and `xjadeo` must be accessible in $PATH for video to work. |
Motivation
Video support in Adour with
videoSupportThis adds a
booloption that, when set totrue, enables videotimeline support for the Ardour DAW. This is commonly useful for
soundtrack composition, sound design for film, etc.
When enabled,
videoSupportensures that bothharvidandxjadeoareavailable to the
ardour6exe via the PATH.harviddecodes the videostream in real-time to produce still images (I think for thumbnail
support for the timeline?).
xjadeoacts as a video monitoring windowthat whose playback position is synchronised to the Ardour playhead.
videoSupportremains disabled by default, preserving the originalbehaviour.
Video support can be added to ardour in your system or home
configuration package list with:
harvidandxjadeoharviddecodes still images from movie files and serves them via HTTP.xjadeois an "X Jack Video Monitor".Both executables must be available via
PATHin order for ardour's videotimeline support to work. You can read more about both tools in their
respective
metaattributes.Tested builds of ardour both with and without
videoSupportand bothappear to work nicely. Both
harvidandxjadeoalso appear to workas intended from their respective CLIs.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @cillianderoiste @magnetophon, current maintainers of the ardour package.