Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire-desktop: linux 3.21.2936 -> 3.22.2937 #115180

Merged
merged 3 commits into from Mar 6, 2021

Conversation

toonn
Copy link
Contributor

@toonn toonn commented Mar 5, 2021

Motivation for this change

Version bump.
I also included a change to my maintainer email.

I expect a new release for macOS as well soon which I will add to this PR if it's not merged by then.

I usually backport these version bumps but have receive mixed messages about doing that. Please let me know if/when I can backport this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 115180 at dd4b13b run on x86_64-linux 1

1 package built:
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/networking/instant-messengers/wire-desktop/default.nix:100:5:

        |
    100 |     installPhase = ''
        |     ^
    

@toonn
Copy link
Contributor Author

toonn commented Mar 5, 2021

I'm hesitant to add the runHook suggestions because those phases don't seem to be necessary in this case and more moving parts means more places to mess things up. This expression really just installs a .deb or .pkg, however, I will make the changes if reviewers say they're desirable.

@SuperSandro2000
Copy link
Member

I usually backport these version bumps but have receive mixed messages about doing that. Please let me know if/when I can backport this.

Sure, why not? As long as I don't need to do it and test it.

@SuperSandro2000
Copy link
Member

I'm hesitant to add the runHook suggestions because those phases don't seem to be necessary in this case and more moving parts means more places to mess things up. This expression really just installs a .deb or .pkg, however, I will make the changes if reviewers say they're desirable.

Please read https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md. So far I don't know any case where it broke something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants