Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhallPackages: add recurseIntoAttrs #115184

Merged
merged 1 commit into from Mar 5, 2021
Merged

dhallPackages: add recurseIntoAttrs #115184

merged 1 commit into from Mar 5, 2021

Conversation

Profpatsch
Copy link
Member

dhallPackages were not built by the hydra, because the
recurseIntoAttrs calls was missing (all other package sets use it to
make hydra build the packages).

cc @Gabriel439

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Profpatsch
dhallPackages: add recurseIntoAttrs
3e01036 
dhallPackages were not built by the hydra, because the
`recurseIntoAttrs` calls was missing (all other package sets use it to
make hydra build the packages).
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 115184 at 3e01036 run on x86_64-linux 1

1 package failed to build:
2 packages built:
  • dhallPackages.Prelude
  • dhallPackages.dhall-kubernetes

@Profpatsch
Copy link
Member Author

Great, seems to work.

@Profpatsch Profpatsch merged commit e75b4c7 into NixOS:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Profpatsch @r-rmcgibbo