Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polkadot: 0.8.28-1 -> 0.8.29 #115190

Merged
merged 3 commits into from Mar 6, 2021
Merged

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Mar 5, 2021

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 5, 2021

Result of nixpkgs-review pr 115190 at 0e33ee4 run on aarch64-linux 1

1 package built:
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/blockchains/polkadot/default.nix:38:5:

       |
    38 |     license = licenses.gpl3;
       |     ^
    

Result of nixpkgs-review pr 115190 at 0e33ee4 run on x86_64-linux 1

1 package built:
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/blockchains/polkadot/default.nix:38:5:

       |
    38 |     license = licenses.gpl3;
       |     ^
    

@SuperSandro2000 SuperSandro2000 changed the title Polkadot 0.8.29 polkadot: 0.8.28-1 -> 0.8.29 Mar 5, 2021
@asymmetric
Copy link
Contributor Author

@r-rmcgibbo's suggestion has been fixed.

@SuperSandro2000
Copy link
Member

@r-rmcgibbo's suggestion has been fixed.

That is a bot and will probably not answer you.

@SuperSandro2000 SuperSandro2000 merged commit 877a51d into NixOS:master Mar 6, 2021
@asymmetric asymmetric deleted the polkadot-0.8.29 branch March 6, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants