nim: cross-compilation fixes #115195
Merged
nim: cross-compilation fixes #115195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SuperSandro2000 Yes, strictDeps is what I want, thanks. |
|
I'm having problems getting cross-complation to work where the build platform is GCC and the target platform is Clang. |
ehmry
force-pushed
the
nim
branch
2 times, most recently
from
3371538
to
114ca02
Compare
Comment on lines
+259
to
261
| "--prefix PATH : ${lib.makeBinPath [ buildPackages.gdb ]}:${ | ||
| placeholder "out" | ||
| }/bin" |
There was a problem hiding this comment.
Suggested change
| "--prefix PATH : ${lib.makeBinPath [ buildPackages.gdb ]}:${ | |
| placeholder "out" | |
| }/bin" | |
| "--prefix PATH : ${lib.makeBinPath [ buildPackages.gdb ]}:${placeholder "out"}/bin" |
| # is not documented, so duplicate the configuration across both files. | ||
| '' | ||
| runHook preBuild | ||
| cat >> config/config.nims << WTF |
There was a problem hiding this comment.
I would prefer if EOF for heredocs are used. That is more common and for everyone easy to spot.
If you need more build power or some testing and some limited help on darwin just hit me up. |
* Import with callPackages * Use buildPackages for building a cross-compiler * Patch-out potential conflicts in nim.cfg * Generate a configuration with toolchain detection * Build with strictDeps enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import with callPackages, use buildPackages for building a cross-compiler, cleanup nim.cfg so that it does not conflict with our configuration.
Motivation for this change
Cross-compilation doesn't work right now, the wrapper takes a Nim compiler built for the targetPlatform.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)