Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cvxpy: 1.1.10 -> 1.1.11 #115210

Merged
merged 1 commit into from Mar 6, 2021
Merged

python3Packages.cvxpy: 1.1.10 -> 1.1.11 #115210

merged 1 commit into from Mar 6, 2021

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Mar 5, 2021 •
edited

Motivation for this change

https://github.com/cvxgrp/cvxpy/releases/tag/v1.1.11

Things done

EDIT: downstream python3Packages.qiskit-ibmq-provider is broken with this PR, should be fixed in #115211 (tested locally w/ both PRs, works).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 5, 2021 •
edited

Result of nixpkgs-review pr 115210 at 0074b7b run on aarch64-linux 1

15 packages failed to build:

Result of nixpkgs-review pr 115210 at 0074b7b run on x86_64-linux 1

1 package failed to build:
14 packages built:

@SuperSandro2000
Copy link
Member

EDIT: downstream python3Packages.qiskit-ibmq-provider is broken with this PR, should be fixed in #115211 (tested locally w/ both PRs, works).

next time just combine the PRs.

@drewrisinger
Copy link
Contributor Author

EDIT: downstream python3Packages.qiskit-ibmq-provider is broken with this PR, should be fixed in #115211 (tested locally w/ both PRs, works).

next time just combine the PRs.

I didn't know it was broken until I ran the full nix-review on this PR. There's no real reason it should be, the failing test was some web-related test, which shouldn't relate to an optimization package like cvxpy.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115210 run on x86_64-linux 1

15 packages built:
  • python37Packages.cvxpy
  • python37Packages.qiskit
  • python37Packages.qiskit-aer
  • python37Packages.qiskit-aqua
  • python37Packages.qiskit-ignis
  • python38Packages.cvxpy
  • python38Packages.qiskit
  • python38Packages.qiskit-aer
  • python38Packages.qiskit-aqua
  • python38Packages.qiskit-ignis
  • python39Packages.cvxpy
  • python39Packages.qiskit
  • python39Packages.qiskit-aer
  • python39Packages.qiskit-aqua
  • python39Packages.qiskit-ignis

@SuperSandro2000 SuperSandro2000 merged commit 1bbeab0 into NixOS:master Mar 6, 2021
@drewrisinger drewrisinger deleted the dr-pr-cvxpy-bump branch March 6, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @r-rmcgibbo @SuperSandro2000