treewide: unzip buildInputs to nativeBuildInputs (2) #115228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siraben
requested review from
alyssais,
andir,
cdepillabout,
danieldk,
Ericson2314,
FRidh,
jonringer,
matthewbauer,
nbp,
Profpatsch,
stigtsp,
ttuegel and
zowoq
as code owners
ofborg
bot
added
6.topic: fetch
6.topic: GNOME
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 501+
10.rebuild-linux: 501-1000
and removed
6.topic: TeX
siraben
force-pushed
the
unzip-buildInputs
branch
from
70bdbf5
to
4f0cdb6
Compare
SuperSandro2000
approved these changes
Mar 6, 2021
|
Based on the comments, I think the modules are fine. Those are a small rebuild if not, too. |
jtojnar
added a commit
that referenced
this pull request
Mar 13, 2021
Reverted #115228 for kodi to avoid conflict. It does not look like unzip would be used but not investigating now to speed up merge conflict resolution.
jtojnar
reviewed
Mar 13, 2021
| @@ -177,7 +177,7 @@ in stdenv.mkDerivation { | |||
| libogg libvorbis flac libxslt systemd | |||
| lzo libcdio libmodplug libass libbluray | |||
| sqlite libmysqlclient avahi lame | |||
| curl bzip2 zip unzip glxinfo | |||
| curl bzip2 zip glxinfo | |||
There was a problem hiding this comment.
Looks like this has not been removed from the argument list.
There was a problem hiding this comment.
on staging it is there and unused. On staging-next it is also in buildInputs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Helps with cross-compilation. See #112302.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)