Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] chromium: 89.0.4389.72 -> 89.0.4389.82 #115244

Merged
merged 3 commits into from Mar 7, 2021
Merged

[20.09] chromium: 89.0.4389.72 -> 89.0.4389.82 #115244

merged 3 commits into from Mar 7, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented Mar 6, 2021

Motivation for this change

Backport of #115243.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
chromium: Remove google_default_client_{id,secret}
7895284 
Reason: Google is limiting access to their private Chrome APIs starting
on March 15, 2021 [0]. Closes NixOS#110245.

From the mailing list thread [1]:
"The changes we announced affect the OAuth 2.0 client id and secret
which are used for signing into Chrome, not the API key."
"To avoid using that API, it's sufficient to either not set the OAuth
2.0 credentials, or disabling the Google signin integration" (e.g. by
passing the flag --allow-browser-signin=false)

[0]: https://blog.chromium.org/2021/01/limiting-private-api-availability-in.html
[1]: https://groups.google.com/a/chromium.org/g/chromium-packagers/c/SG6jnsP4pWM/

(cherry picked from commit dc9f2c5)
@primeos
chromium: Add my script to generate the commit messages
0004b52 
Might not be that readable and reliable but it should get the job done.

(cherry picked from commit 9004162)
@primeos
chromiumDev: 90.0.4427.5 -> 90.0.4430.11
1b971a0 
(cherry picked from commit 8671fe7)
@primeos primeos marked this pull request as ready for review March 7, 2021 10:41
@primeos
Copy link
Member Author

primeos commented Mar 7, 2021

nixosTests.chromium succeeded.

@primeos primeos merged commit 9ab38ae into NixOS:release-20.09 Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos