Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncthing: 1.13.1 -> 1.14.0 #115274

Merged
merged 1 commit into from Mar 7, 2021
Merged

syncthing: 1.13.1 -> 1.14.0 #115274

merged 1 commit into from Mar 7, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 6, 2021

Motivation for this change

https://forum.syncthing.net/t/syncthing-v1-14-0/16430

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 115274 at e773a76 run on aarch64-linux 1

1 package marked as broken and skipped:
  • syncthing-gtk
5 packages built:
1 suggestion:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/networking/syncthing/default.nix:21:9:

       |
    21 |         ./add-stcli-target.patch
       |         ^
    

@marsam marsam merged commit ff9fb5a into NixOS:master Mar 7, 2021
@marsam marsam deleted the update-syncthing branch March 7, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants