vscx/ms-vsliveshare-vsliveshare: 1.0.2902 -> 1.0.3912

[deviant]

This was broken on vscode >= 1.53.0.

Cleans up a bunch of things:

• uses substitution over sed & wrappers, messing with $PATH less and making everything more clear
• substitutes xprop in the correct place (this was never actually used in the launcher scripts)
• substitutes references to xsel — although this isn't strictly necessary, as it bundles the binary(!)
• substitutes hardcoded /bin/bash (the vsls scheme handler cannot have actually worked before on NixOS)

Supersedes #112909.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115277 run on x86_64-linux 1

1 package built:

• vscode-extensions.ms-vsliveshare.vsliveshare

[teto]

I've just tested it and it fixed for me. Now I wonder if #115249 wont break it again ?

[deviant]

@teto: I would hope not! This is the latest version as per mp.vs/MS-vsliveshare.vsliveshare.

The extension was broken due to not having been updated in nixpkgs for months, while depending on an unstable "proposed" API that was later removed. Having automatic update PRs for VS Code extensions would help prevent future issues of this sort cropping up (and more closely reflect how they're used by normal people). @ryantm, is this something that would be simple to add to your bot?

This is the place for API experiments and proposals.
These API are NOT stable and subject to change. They are only available in the Insiders
distribution and CANNOT be used in published extensions.

Perhaps Microsoft should read their own documentation :)

[jraygauthier]

@deviant: Excellent cleanup of the original draft. 👍

[jraygauthier]

Works fine too here on nixos, using vscode 1.53.2, with extension 1.03912 both local instances built from latest nixpkgs:

$ cd /path/to/latest/nixpkgs
$ nix-build -I nixpkgs=. -E 'with import <nixpkgs> {config={allowUnfree = true;};}; vscode-with-extensions.override {vscodeExtensions = with vscode-extensions; [ms-vsliveshare.vsliveshare];}'
$ ./result/bin/code .