Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smarty3: 3.1.36 -> 3.1.39 #115282

Merged
merged 1 commit into from Mar 7, 2021
Merged

smarty3: 3.1.36 -> 3.1.39 #115282

merged 1 commit into from Mar 7, 2021

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Mar 6, 2021

Motivation for this change

Fixes CVE-2021-26119 and CVE-2021-26120.

https://github.com/smarty-php/smarty/blob/v3.1.39/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • smarty3

@LeSuisse LeSuisse added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 6, 2021
@ofborg ofborg bot requested a review from dasJ March 6, 2021 19:17
@SuperSandro2000 SuperSandro2000 merged commit 5d889e6 into NixOS:master Mar 7, 2021
@erictapen
Copy link
Member

Backported in 7b21af7.

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 16, 2021
@LeSuisse LeSuisse deleted the smarty3-3.1.39 branch January 28, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeSuisse @erictapen @SuperSandro2000