Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow firefox building in 32-bit systems #115314

Merged
merged 1 commit into from Mar 8, 2021
Merged

Allow firefox building in 32-bit systems #115314

merged 1 commit into from Mar 8, 2021

Conversation

viric
Copy link
Member

@viric viric commented Mar 7, 2021 •
edited

Allow firefox building in 32-bit systems

Even if not as much optimized (LTO)

Motivation for this change

At least have a running firefox in 32-bit systems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@viric viric requested a review from cleverca22 March 7, 2021 07:52
@ofborg ofborg bot requested review from lovesegfault and edolstra March 7, 2021 08:00
@viric
Copy link
Member Author

viric commented Mar 7, 2021

I added a 2nd commit because I was, in fact, porting the change from release-20.09 to master; and master introduced ltoSupport.

@viric
firefox: build in 32-bit systems
d2af381 
Disabling "-g" and LTO so there aren't memory problems.
@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 115314 run on x86_64-linux 1

4 packages built:
  • adoptopenjdk-icedtea-web
  • firefox-esr-78-unwrapped (firefoxPackages.firefox-esr-78)
  • xulrunner (firefox-unwrapped)
  • slimerjs

@lovesegfault lovesegfault merged commit e52507a into NixOS:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

@cleverca22 cleverca22 Awaiting requested review from cleverca22

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@viric @lovesegfault