Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calamares: fix python modules #115344

Closed
wants to merge 3 commits into from
Closed

calamares: fix python modules #115344

wants to merge 3 commits into from

Conversation

Gaelan
Copy link
Contributor

@Gaelan Gaelan commented Mar 7, 2021

Motivation for this change

Calamares wants a boost with python support. It builds without it, but omits any python modules, which are a lot of the interesting ones. This PR also incorporates #114016, which is necessary to build calamares on master.

(As a side note, it's a shame that kpmcore runs on DBus now; as of a few weeks ago, it was possible to run Calamares without any reliance on the global system, which would have made it possible to use any system with Nix on it as a NixOS installer. Ah well.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

oxalica and others added 3 commits March 5, 2021 00:29
@oxalica
{partition-manager,libsForQt5.kpmcore}: 3.3.1 -> 4.2.0 and fix build
2e024cb
@oxalica
nixos/partition-manager: init
bb0bc3c
@Gaelan
calamares: fix python and enable parallel builds
c7ae852 
At some point boost started requiring enablePython to build with python
support, which calamares wants. While we're at, turn on parallel builds;
they were disabled at some point with no justification, and it seems to
build and run fine without.
@ofborg ofborg bot requested review from manveru, oxalica and peterhoeg March 7, 2021 17:38
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 115344 at c7ae852 run on x86_64-linux 1

1 package marked as broken and skipped:
  • libsForQt512.kpmcore
4 packages built:

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115344 run on x86_64-linux 1

1 package marked as broken and skipped:
  • libsForQt512.kpmcore
1 package blacklisted:
  • tests.nixos-functions.nixos-test
4 packages built:
  • calamares
  • libsForQt5.kpmcore (libsForQt515.kpmcore ,plasma5Packages.kpmcore)
  • libsForQt514.kpmcore
  • partition-manager

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

calamares:

warning: build-tools-in-build-inputs
util-linux is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/tools/misc/calamares/default.nix:18:3:

   |
18 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

SuperSandro2000
SuperSandro2000 approved these changes Mar 7, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the module.

@Gaelan
Copy link
Contributor Author

Gaelan commented Mar 7, 2021

The module is from #114016; that PR should probably be merged separately before this one

@stale
Copy link

stale bot commented Sep 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 6, 2021
@Artturin
Copy link
Member

Artturin commented Sep 6, 2021

Added python support to boost #136929

@Artturin Artturin closed this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@manveru manveru Awaiting requested review from manveru

@oxalica oxalica Awaiting requested review from oxalica

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Gaelan @r-rmcgibbo @SuperSandro2000 @Artturin @FRidh @oxalica