Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc-wrapper: remove quoting of response file #115479

Merged
merged 1 commit into from Mar 9, 2021

Conversation

thefloweringash
Copy link
Member

Fixes build failures with clang:

clang-7: error: unknown argument: '-fPIC                -target'
clang-7: error: no such file or directory: '@<(printf %qn        -O2'
clang-7: error: no such file or directory: 'x86_64-apple-darwin'

Introduced by 60c5cf9 in #112449

Motivation for this change

Fix darwin stdenv on staging-next.

The problem is present on both staging and staging-next, and I don't know which branch to send this to so I picked one.

cc @angerman @matthewbauer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes build failures with clang:

    clang-7: error: unknown argument: '-fPIC                -target'
    clang-7: error: no such file or directory: '@<(printf %qn        -O2'
    clang-7: error: no such file or directory: 'x86_64-apple-darwin'

Introduced by 60c5cf9 in NixOS#112449
@Mic92
Copy link
Member

Mic92 commented Mar 9, 2021

We merge staginx-next into staging automatically every six hours.

@Mic92 Mic92 merged commit c5eea46 into NixOS:staging-next Mar 9, 2021
@thefloweringash thefloweringash deleted the cc-wrapper-quote branch March 9, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants