Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerTools: Do not lowercase image tag in buildImage #115491

Merged
merged 1 commit into from
Mar 9, 2021
Merged

dockerTools: Do not lowercase image tag in buildImage #115491

merged 1 commit into from
Mar 9, 2021

Conversation

NasaGeek
Copy link
Contributor

@NasaGeek NasaGeek commented Mar 9, 2021

Closes #115455

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NasaGeek NasaGeek requested a review from roberth as a code owner March 9, 2021 09:07
roberth
roberth approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@roberth roberth merged commit 2deb6cf into NixOS:master Mar 9, 2021
Profpatsch
Profpatsch reviewed Jun 1, 2021
View reviewed changes
Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot the bit in passthru.imageTag @NasaGeek

roberth added a commit to hercules-ci/nixpkgs that referenced this pull request Jun 1, 2021
@roberth
dockerTools: Fix passthru image tag
ff55c41 
It should match the actual image tag.
This fixes the problem introduced in 00996b5
NixOS#115491 (review)
@roberth roberth mentioned this pull request Jun 1, 2021
Merged
9 tasks
github-actions bot pushed a commit that referenced this pull request Jun 2, 2021
@roberth @github-actions
dockerTools: Fix passthru image tag
fc30ee8 
It should match the actual image tag.
This fixes the problem introduced in 00996b5
#115491 (review)

(cherry picked from commit ff55c41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch left review comments

@roberth roberth roberth approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dockerTools: Tag is unnecessarily lowercased in buildImage function
4 participants
@NasaGeek @roberth @Profpatsch @Janik-Haag