Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watir2 #115501

Closed
wants to merge 2 commits into from
Closed

Watir2 #115501

wants to merge 2 commits into from

Conversation

ngiger
Copy link
Contributor

@ngiger ngiger commented Mar 9, 2021

Motivation for this change

I use watir for testing my gems on rubygems. And I found and old issue, that somebody needed this gem for NixOS, too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [*] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [* ] Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 9, 2021

Result of nixpkgs-review pr 115501 at 5ad508c run on aarch64-linux 1

1 package built:
1 suggestion:
  • warning: unused-argument

    Unused argument: bundlerUpdateScript.
    Near pkgs/applications/misc/watir/default.nix:1:20:

      |
    1 | { lib, bundlerEnv, bundlerUpdateScript }:
      |                    ^
    

Result of nixpkgs-review pr 115501 at 5ad508c run on x86_64-linux 1

1 package built:
1 suggestion:
  • warning: unused-argument

    Unused argument: bundlerUpdateScript.
    Near pkgs/applications/misc/watir/default.nix:1:20:

      |
    1 | { lib, bundlerEnv, bundlerUpdateScript }:
      |                    ^
    

Comment on lines 25137 to +25138
wavebox = callPackage ../applications/networking/instant-messengers/wavebox { };
watir = callPackage ../applications/misc/watir { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wavebox = callPackage ../applications/networking/instant-messengers/wavebox { };
watir = callPackage ../applications/misc/watir { };
wavebox = callPackage ../applications/networking/instant-messengers/wavebox { };
watir = callPackage ../applications/misc/watir { };

@stale
Copy link

stale bot commented Sep 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 19, 2021
@Artturin Artturin closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants