haskellPackages: Unbreak fakedata and fakedata-quickcheck and string-random

[markus1189]

• haskellPackages.fakedata: unbreak
• haskellPackages.fakedata-quickcheck: unbreak
• haskellPackages.string-random: unbreak

Motivation for this change

All of the packages build fine

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[cdepillabout]

haskellPackages.string-random appears to be a dependency of fakedata, and it is also marked broken.

Could you mark string-random as unbroken?

[markus1189]

haskellPackages.string-random appears to be a dependency of fakedata, and it is also marked broken.

Could you mark string-random as unbroken?

Hmm I can't find an entry in pkgs/development/haskell-modules/configuration-hackage2nix.yaml and grepping did not really bring something up. But it is marked broken... 😕

[cdepillabout]

@markus1189 Good point.

@maralorn Sorry, I feel like you keep explaining this to me and I keep immediately forgetting it. What's the reason that a package will be marked broken even though there is no entry in the broken packages list in configuration-hackage2nix.yaml?

Above, @markus1189 is saying that string-random is marked broken in hackage-packages.nix even though there is no string-random in the broken packages list in configuration-hackage2nix.yaml.

[maralorn]

@cdepillabout The explanation normally is, that the package has a build-input which cannot be found on hackage.

In this case however I can find string-random when grepping through the broken list in the yaml file. @markus1189 can you check again?

[cdepillabout]

@maralorn Oh, I'm sorry, you're completely right. string-random is in the broken packages list in pkgs/development/haskell-modules/configuration-hackage2nix.yaml. I don't know how I missed that when I looked for it.

@markus1189 If you remove string-random from the broken list I'll merge this in.

[markus1189]

@cdepillabout Oops I guess I was grepping after already having removed the line 🤦 sorry for that :)

Thanks for having a look to both of you, I also removed string-random now.

[cdepillabout]

Thanks, this looks good!