Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] pytest-xprocess: 0.17.0 -> 0.17.1 #115521

Closed
wants to merge 1 commit into from

Conversation

collares
Copy link
Member

@collares collares commented Mar 9, 2021

Motivation for this change

Should fix the Werkzeug failure at https://hydra.nixos.org/build/138612948, see pytest-dev/pytest-xprocess#61

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@collares collares changed the title pytest-xprocess: 0.17.0 -> 0.17.1 [staging-next] pytest-xprocess: 0.17.0 -> 0.17.1 Mar 9, 2021
@SuperSandro2000
Copy link
Member

I already fixed Werkzeug in staging. babb021#diff-7c765cc9768cdae049f8712b4ef719bc94ec8ec2e8df2dd50ddf14c6acd4e580

Does this replace the linked commit? If so we should remove the overwrite. Not sure what the best way here will be.

@collares
Copy link
Member Author

collares commented Mar 9, 2021

@SuperSandro2000 You should keep your fix, because looking more carefully I think Werkzeug's testsuite only uses pytest-timeout, not pytest-xprocess, so I don't think my patch would help much. But this is breaking staging-next evaluation, so I think your fix should land there too? I don't know the procedure, to be honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants