Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonist: 0.3.0 -> 0.4.1 #115661

Merged
merged 1 commit into from Mar 10, 2021
Merged

harmonist: 0.3.0 -> 0.4.1 #115661

merged 1 commit into from Mar 10, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2021

Motivation for this change

Unfortunately, I am no longer interested in supporting this package. This is the last update from me. 馃懡
The package has been updated, the maintainer has been removed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 10, 2021

Result of nixpkgs-review pr 115661 at 6dea1d8 run on x86_64-linux 1

1 package built:
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/games/harmonist/default.nix:32:5:

       |
    32 |     maintainers = with maintainers; [];
       |     ^
    

Result of nixpkgs-review pr 115661 at 6dea1d8 run on aarch64-linux 1

1 package built:
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/games/harmonist/default.nix:32:5:

       |
    32 |     maintainers = with maintainers; [];
       |     ^
    

@SuperSandro2000 SuperSandro2000 merged commit 0cc70c1 into NixOS:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants