polar-bookshelf: add version 1.100.14 #115674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The polar-bookshelf package is outdated. Unstable has 2.0.42 but version 2 is a cloud only application and incompatible with version 1.100.14 is the final version 1 according to the developer https://www.reddit.com/r/PolarBookshelf/comments/j9yfbx/polar_110014_last_1x_version_with_autoupdates/
dansbandit
changed the title
2 tasks
SuperSandro2000
requested changes
Mar 10, 2021
Comment on lines
+83
to
+91
| meta = { | ||
| homepage = "https://getpolarized.io/"; | ||
| description = "Personal knowledge repository for PDF and web content supporting incremental reading and document annotation"; | ||
| license = lib.licenses.gpl3; | ||
| platforms = lib.platforms.linux; | ||
| maintainers = [ lib.maintainers.noneucat ]; | ||
| }; | ||
|
|
||
| } |
There was a problem hiding this comment.
Suggested change
| meta = { | |
| homepage = "https://getpolarized.io/"; | |
| description = "Personal knowledge repository for PDF and web content supporting incremental reading and document annotation"; | |
| license = lib.licenses.gpl3; | |
| platforms = lib.platforms.linux; | |
| maintainers = [ lib.maintainers.noneucat ]; | |
| }; | |
| } | |
| meta = with lib; { | |
| homepage = "https://getpolarized.io/"; | |
| description = "Personal knowledge repository for PDF and web content supporting incremental reading and document annotation"; | |
| license = licenses.gpl3; | |
| platforms = platforms.linux; | |
| maintainers = [ maintainers.noneucat ]; | |
| }; | |
| } |
gpl3Only or gpl3Plus?
There was a problem hiding this comment.
gpl3Only according to upstream package.json.
|
Also please do not create PRs from your master. This creates various issues in certain scenarios. |
|
Thank you for your suggestions! I will incorporate these suggestions in a separate branch and create another pull request. Is that OK? |
|
I incorporated the suggested changes and created a new pull request PR: #116822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polar-bookshelf package is outdated. Unstable has 2.0.42 but version 2 is a cloud only application and incompatible with version 1.100.14 which is the final version 1 according to the developer. https://www.reddit.com/r/PolarBookshelf/comments/j9yfbx/polar_110014_last_1x_version_with_autoupdates/
Adapted the paths from https://github.com/NixOS/nixpkgs/blob/nixos-20.09/pkgs/applications/misc/polar-bookshelf/default.nix
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)