Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreutils: enable tests for non-standard store path #115678

Merged
merged 2 commits into from Mar 20, 2021
Merged

coreutils: enable tests for non-standard store path #115678

merged 2 commits into from Mar 20, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 10, 2021

Motivation for this change

Revert bb73e25, run appropriate tests even on systems with store in /nix/store

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
coreutils: enable tests for non-standard store path
25f8e0c 
Tests don't fail because of a different store path, but for other reasons like
lack of sandboxing. Those tests should be disabled explicitly.
@veprbl
coreutils: disable df-symlink test
2e0d0b4
@ofborg ofborg bot requested a review from edolstra March 10, 2021 03:51
@veprbl veprbl added this to WIP in Staging via automation Mar 10, 2021
@veprbl veprbl moved this from WIP to Needs review in Staging Mar 10, 2021
@FRidh FRidh merged commit 72aa2d1 into NixOS:staging Mar 20, 2021
Staging automation moved this from Needs review to Done Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: non-nixos 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @FRidh