python38Packages.percol: python3 support

[illustris]

Motivation for this change

The percol package is currently marked as broken on python3

Things done

• Add the python-cmigemo package from pypi
• Update percol from 0.1.0 to git rev. 4b28037

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[illustris]

@SuperSandro2000 changes made as requested, please review

[illustris]

Hi. Can this be merged? Are there any further changes necessary?

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115729 run on x86_64-linux 1

4 packages built:

• python38Packages.cmigemo
• python38Packages.percol
• python39Packages.cmigemo
• python39Packages.percol

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python38Packages.cmigemo:

warning: python-include-tests
Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

[illustris]

@SuperSandro2000 I've added pytest for cmigemo. percol didn't have tests, so I added pythonImportsCheck.

[SuperSandro2000]

@SuperSandro2000 I've added pytest for cmigemo. percol didn't have tests, so I added pythonImportsCheck.

pythonImportsCheck can be added to all python packages even if running tests. They make sure the python package can be imported which is important that all required packages are there even without checkInputs.

Also sorry for letting you wait. There are just to many PRs and to little time.

[illustris]

Yes, the number of PRs is terrifying XD

Should I add pythonImportsCheck to cmigemo? Looks like pytest already tests this
https://github.com/mooz/python-cmigemo/blob/ecf0c9487bf9e54ab03aebfc6a2935939cd8881f/test/test_cmigemo.py#L4

[SuperSandro2000]

Should I add pythonImportsCheck to cmigemo? Looks like pytest already tests this

It wouldn't hurt because checkInputs has some extra packages most likely which are not available in the final environment.

[illustris]

Added import check:
https://github.com/NixOS/nixpkgs/pull/115729/files#diff-d5dc448c3c8c0ff51881e3516fc05939ac863c6e8a641dfb8c06ab3fb31a3699R28