Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.lf-vim: switch dependency to vim-floaterm #115736

Merged
merged 1 commit into from Mar 10, 2021
Merged

vimPlugins.lf-vim: switch dependency to vim-floaterm #115736

merged 1 commit into from Mar 10, 2021

Conversation

jupblb
Copy link
Contributor

@jupblb jupblb commented Mar 10, 2021

Switch lf-vim dependency from vim-bbye to vim-floaterm because of ptzz/lf.vim@9cc8789

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jupblb
vimPlugins.lf-vim: switch dependency to vim-floaterm
c54bb3d 
Switch `lf-vim` dependency from `vim-bbye` to `vim-floaterm` because of ptzz/lf.vim@9cc8789
@jupblb jupblb requested a review from jonringer as a code owner March 10, 2021 10:08
@SuperSandro2000 SuperSandro2000 merged commit dd160e4 into NixOS:master Mar 10, 2021
@jupblb jupblb deleted the patch-1 branch March 10, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jupblb @SuperSandro2000