Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex: 1.21.4.4079-1b7748a7b -> 1.22.0.4163-d8c4875dd #115741

Merged
merged 1 commit into from Mar 21, 2021
Merged

plex: 1.21.4.4079-1b7748a7b -> 1.22.0.4163-d8c4875dd #115741

merged 1 commit into from Mar 21, 2021

Conversation

MayNiklas
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@badmutex badmutex mentioned this pull request Mar 15, 2021
Closed
bachp
bachp approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected

@SuperSandro2000 SuperSandro2000 merged commit d5d0bdb into NixOS:master Mar 21, 2021
@MayNiklas MayNiklas mentioned this pull request Jul 22, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badmutex badmutex badmutex approved these changes

@bachp bachp bachp approved these changes

@pjones pjones Awaiting requested review from pjones

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@LnL7 LnL7 Awaiting requested review from LnL7

@Forkk Forkk Awaiting requested review from Forkk

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MayNiklas @badmutex @bachp @SuperSandro2000