Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide (darwin): fix or enable darwin build for many packages (4) #115756

Merged
merged 17 commits into from Mar 16, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Mar 10, 2021

Motivation for this change

See #114976 for details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Mar 10, 2021

Result of nixpkgs-review pr 115756 run on x86_64-darwin 1

25 packages built:
  • analog
  • coan
  • lambda-mod-zsh-theme
  • makefile2graph
  • midicsv
  • mnemonicode
  • p910nd
  • perl530Packages.AlienTidyp
  • perl530Packages.HTMLTidy
  • perl532Packages.AlienTidyp
  • perl532Packages.HTMLTidy
  • postsrsd
  • python38Packages.tinyobjloader-py
  • python39Packages.tinyobjloader-py
  • r2mod_cli
  • restya-board
  • rocm-cmake
  • routinator
  • swarm
  • tidyp
  • tinyobjloader
  • tllist
  • udpt
  • utf8cpp
  • vcg

@siraben
Copy link
Member Author

siraben commented Mar 10, 2021

Wowza!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115756 run on x86_64-linux 1

3 packages built:
  • analog
  • midicsv
  • p910nd

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

analog:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/tools/admin/analog/default.nix:33:5:

   |
33 |     license = lib.licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115756 run on x86_64-darwin 1

21 packages built:
  • analog
  • coan
  • lambda-mod-zsh-theme
  • makefile2graph
  • midicsv
  • mnemonicode
  • p910nd
  • postsrsd
  • python38Packages.tinyobjloader-py
  • python39Packages.tinyobjloader-py
  • r2mod_cli
  • restya-board
  • rocm-cmake
  • routinator
  • swarm
  • tidyp
  • tinyobjloader
  • tllist
  • udpt
  • utf8cpp
  • vcg

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

analog:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/tools/admin/analog/default.nix:33:5:

   |
33 |     license = lib.licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@siraben siraben force-pushed the darwin-mass-fix-buildInputs=0 branch 2 times, most recently from d5174ec to 0d7af40 Compare March 11, 2021 18:53
@risicle
Copy link
Contributor

risicle commented Mar 13, 2021

Needs another rebase, but all builds for me on macos 10.14 - nice work.

@siraben siraben force-pushed the darwin-mass-fix-buildInputs=0 branch from 0d7af40 to 593629b Compare March 14, 2021 04:42
@siraben
Copy link
Member Author

siraben commented Mar 14, 2021

Rebased.

@siraben
Copy link
Member Author

siraben commented Mar 15, 2021

@SuperSandro2000 ping

@SuperSandro2000 SuperSandro2000 merged commit bd38cc9 into NixOS:master Mar 16, 2021
@siraben siraben deleted the darwin-mass-fix-buildInputs=0 branch March 16, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants