Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpvScripts.thumbnail: init at unstable-2020-01-16 #115800

Merged
merged 1 commit into from Mar 20, 2021
Merged

mpvScripts.thumbnail: init at unstable-2020-01-16 #115800

merged 1 commit into from Mar 20, 2021

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Mar 10, 2021

Motivation for this change

A lua script to show preview thumbnails in mpv's OSC seekbar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@figsoda
Copy link
Member Author

figsoda commented Mar 18, 2021

Any chance this gets merged?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/484

@SuperSandro2000 SuperSandro2000 merged commit 884039f into NixOS:master Mar 20, 2021
@figsoda figsoda deleted the mpv-thumbnail-script branch March 21, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@figsoda @nixos-discourse @SuperSandro2000